summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Burnicki <martin.burnicki@meinberg.de>2023-02-23 15:22:40 +0100
committerMartin Burnicki <martin.burnicki@meinberg.de>2023-02-23 15:22:40 +0100
commit3bcfdbb2e786e1c239a8e1cd0cf4a307c9e80c2f (patch)
tree02111bdbac058c05fffefa2dbaee625c175b4447
parent6e8b4353ae323280696ea898cc5a38855982481f (diff)
downloadmbgtools-lx-3bcfdbb2e786e1c239a8e1cd0cf4a307c9e80c2f.tar.gz
mbgtools-lx-3bcfdbb2e786e1c239a8e1cd0cf4a307c9e80c2f.zip
mbgdevio: Fix a bug when saving IRIG input settings
In mbg_save_all_irig_rx_settings() the presence of a timecode output was incorrectly checked instead of the presence of a timecode input, so the call succeeded only if the device also had a timecode output. Also updated some comments.
-rw-r--r--mbglib/common/mbgdevio.c11
-rw-r--r--mbglib/common/mbgdevio.h6
2 files changed, 12 insertions, 5 deletions
diff --git a/mbglib/common/mbgdevio.c b/mbglib/common/mbgdevio.c
index 34fa11c..b3f7b97 100644
--- a/mbglib/common/mbgdevio.c
+++ b/mbglib/common/mbgdevio.c
@@ -1,7 +1,7 @@
/**************************************************************************
*
- * $Id: mbgdevio.c 1.58 2022/12/21 14:55:38 martin.burnicki REL_M $
+ * $Id: mbgdevio.c 1.59 2023/02/23 10:51:56 martin.burnicki REL_M $
*
* Copyright (c) Meinberg Funkuhren, Bad Pyrmont, Germany
*
@@ -10,6 +10,11 @@
*
* -----------------------------------------------------------------------
* $Log: mbgdevio.c $
+ * Revision 1.59 2023/02/23 10:51:56 martin.burnicki
+ * Fixed a bug in mbg_save_all_irig_rx_settings(), which incorrectly
+ * checked for the presence of a timecode output instead of
+ * a timecode input.
+ * Also updated some comments.
* Revision 1.58 2022/12/21 14:55:38 martin.burnicki
* Quieted a potential compiler warning.
* Revision 1.57 2022/08/23 15:59:09 martin.burnicki
@@ -5601,7 +5606,7 @@ _MBG_API_ATTR int _MBG_API mbg_save_all_irig_rx_settings( MBG_DEV_HANDLE dh,
const MBG_REF_OFFS *p_ref_offs,
const MBG_OPT_SETTINGS *p_opt_settings )
{
- int rc = mbg_chk_dev_has_irig_tx( dh );
+ int rc = mbg_chk_dev_is_tcr( dh );
if ( mbg_rc_is_error( rc ) )
goto out;
@@ -5640,7 +5645,7 @@ out:
* This function fills an ::MBG_IRIG_CTRL_BITS structure with the control function
* bits decoded from the incoming IRIG signal.
*
- * The meaning of these bits depends on the type of IRIG code frame format.
+ * The meaning of these bits depends on the selected time code format.
*
* In some IRIG formats these bits provide some well-known information which can
* also be evaluated by the device. For example, in IEEE 1344 or IEEE C37.118 code
diff --git a/mbglib/common/mbgdevio.h b/mbglib/common/mbgdevio.h
index d31130f..4af60c2 100644
--- a/mbglib/common/mbgdevio.h
+++ b/mbglib/common/mbgdevio.h
@@ -1,7 +1,7 @@
/**************************************************************************
*
- * $Id: mbgdevio.h 1.65 2022/12/21 15:26:48 martin.burnicki REL_M $
+ * $Id: mbgdevio.h 1.66 2023/02/23 10:52:32 martin.burnicki REL_M $
*
* Copyright (c) Meinberg Funkuhren, Bad Pyrmont, Germany
*
@@ -10,6 +10,8 @@
*
* -----------------------------------------------------------------------
* $Log: mbgdevio.h $
+ * Revision 1.66 2023/02/23 10:52:32 martin.burnicki
+ * Updated a doxygen comment.
* Revision 1.65 2022/12/21 15:26:48 martin.burnicki
* Quieted a potential compiler warning.
* Revision 1.64 2022/08/23 16:20:24 martin.burnicki
@@ -3604,7 +3606,7 @@ typedef int _MBG_API MBG_CHK_SUPP_FNC( MBG_DEV_HANDLE dh );
* This function fills an ::MBG_IRIG_CTRL_BITS structure with the control function
* bits decoded from the incoming IRIG signal.
*
- * The meaning of these bits depends on the type of IRIG code frame format.
+ * The meaning of these bits depends on the selected time code format.
*
* In some IRIG formats these bits provide some well-known information which can
* also be evaluated by the device. For example, in IEEE 1344 or IEEE C37.118 code